Skip to content

Conversation

wjzijderveld
Copy link

Failing for Jackaplope Doctrine Dbal transport.

I'm not 100% sure the test is in the right place.

A bit of extra info, according to the JCR specs, this query should be valid.
http://www.day.com/specs/jcr/2.0/6_Query.html#6.7.16%20Comparison

Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

that should be the string "true", not 1

Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

and this property can not be in a nt:folder, that is not valid. the test fixture loading of doctrine-dbal is not validating, so you don't see that. but it must be moved to the jcr:content node

Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

this would then become nt:unstructured

Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

property definitions must come before the child node definitions. when i move this property up to right after the mimeType of jcr:content the test is successful with jackalope-jackrabbit

@dbu
Copy link
Member

dbu commented Feb 9, 2013

apart from the property location this looks correct to me now. @lsmith77 should we wait with merging until we fixed the bug in jackalope-doctrine-dbal or do we merge right away? the later would make sense as its not like the bug is not existing right now, just hidden.

@dbu
Copy link
Member

dbu commented Feb 12, 2013

alright, the test seems correct and jackrabbit is happy with it. i created a bug for doctrine-dbal: jackalope/jackalope-doctrine-dbal#88

dbu added a commit that referenced this pull request Feb 12, 2013
@dbu dbu merged commit ccc5f5e into phpcr:master Feb 12, 2013
@wjzijderveld wjzijderveld deleted the multi-valued-test branch November 24, 2021 11:56
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants