-
Notifications
You must be signed in to change notification settings - Fork 21
Added a multi-valued query test. #81
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Conversation
fixtures/general/base.xml
Outdated
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
that should be the string "true", not 1
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
and this property can not be in a nt:folder, that is not valid. the test fixture loading of doctrine-dbal is not validating, so you don't see that. but it must be moved to the jcr:content node
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
this would then become nt:unstructured
…sert to expect a scalar value instead of an array
fixtures/general/base.xml
Outdated
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
property definitions must come before the child node definitions. when i move this property up to right after the mimeType of jcr:content the test is successful with jackalope-jackrabbit
apart from the property location this looks correct to me now. @lsmith77 should we wait with merging until we fixed the bug in jackalope-doctrine-dbal or do we merge right away? the later would make sense as its not like the bug is not existing right now, just hidden. |
alright, the test seems correct and jackrabbit is happy with it. i created a bug for doctrine-dbal: jackalope/jackalope-doctrine-dbal#88 |
Failing for Jackaplope Doctrine Dbal transport.
I'm not 100% sure the test is in the right place.
A bit of extra info, according to the JCR specs, this query should be valid.
http://www.day.com/specs/jcr/2.0/6_Query.html#6.7.16%20Comparison